Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix flapping Sidekiq test #2227

Closed
fallwith opened this issue Sep 19, 2023 · 1 comment · Fixed by #2236
Closed

CI: fix flapping Sidekiq test #2227

fallwith opened this issue Sep 19, 2023 · 1 comment · Fixed by #2236
Assignees
Labels
oct-dec qtr Possible FY Q3 candidate

Comments

@fallwith
Copy link
Contributor

We have a unit test to confirm that we properly record Sidekiq "internal" errors (errors that take place within Sidekiq's own handling of things and not job specific). That unit test performs the following:

Sidekiq::CLI.instance.handle_exception(exception)

Occasionally - and apparently only via our GitHub Actions runners and not locally - the instance yielded is nil, which doesn't define #handle_exception.

We should see if there's a way to guard against this error with a retry or whatnot.

  1) Error:
SidekiqInstrumentationTest#test_captures_sidekiq_internal_errors:
NoMethodError: undefined method `handle_exception' for nil:NilClass

      config.handle_exception(ex, ctx)
            ^^^^^^^^^^^^^^^^^
    /the/ruby/path/Ruby/3.1.4/x64/lib/ruby/gems/3.1.0/gems/sidekiq-7.1.4/lib/sidekiq/component.rb:48:in `handle_exception'
    /the/runner/path/newrelic-ruby-agent/newrelic-ruby-agent/test/multiverse/suites/sidekiq/sidekiq_instrumentation_test.rb:50:in `block in test_captures_sidekiq_internal_errors'
@workato-integration
Copy link

@fallwith fallwith added estimate Issue needing estimation oct-dec qtr Possible FY Q3 candidate and removed estimate Issue needing estimation labels Sep 19, 2023
@fallwith fallwith self-assigned this Sep 25, 2023
@fallwith fallwith moved this from Triage to In progress in Ruby Engineering Board Sep 25, 2023
@github-project-automation github-project-automation bot moved this from In progress to Code Complete/Done in Ruby Engineering Board Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oct-dec qtr Possible FY Q3 candidate
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant