From c0091a31848a6008eac03e9bf0b7fac03d26eee2 Mon Sep 17 00:00:00 2001 From: Kayla Reopelle Date: Thu, 10 Oct 2024 09:41:34 -0700 Subject: [PATCH] Simplify excluded_settings test --- .../agent/configuration/manager_test.rb | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/test/new_relic/agent/configuration/manager_test.rb b/test/new_relic/agent/configuration/manager_test.rb index 974c02029f..cc2bc78349 100644 --- a/test/new_relic/agent/configuration/manager_test.rb +++ b/test/new_relic/agent/configuration/manager_test.rb @@ -533,20 +533,8 @@ def test_unsatisfied_values_stay_cached def test_logger_does_not_receive_excluded_settings log = with_array_logger(:debug) { @manager.log_config('direction', 'source') }.array.join('') - # TODO: OLD RUBIES - RUBY_VERSION < 3.4 - # The JSON string output changed in Ruby 3.4 to remove the hash rocket - # Pre Ruby 3.4: - # :app_name=>\"test\" - # Ruby 3.4+: - # app_name: \"test\" - # Remove the condition once we support only version 3.4+ - if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.4.0') - assert_includes(log, 'app_name:') - refute_includes(log, 'license_key:') - else - assert_includes(log, ':app_name') - refute_includes(log, ':license_key') - end + assert_includes(log, 'app_name') + refute_includes(log, 'license_key') end def test_reset_cache_return_early_for_jruby