Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink use-xvb option in the test action #50

Open
niksirbi opened this issue Mar 25, 2024 · 1 comment
Open

Rethink use-xvb option in the test action #50

niksirbi opened this issue Mar 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@niksirbi
Copy link
Member

The test action currently accepts an optional "use-xvfb" argument, which in turn uses a headless-gui action (with a specific commit hash).

- name: Run tests with XVFB
      if: ${{ matrix.use-xvfb }}
      # SHA corresponds to v1.1 release
      uses: aganders3/headless-gui@f85dd6316993505dfc5f21839d520ae440c84816
      with:
        run: tox ${{ inputs.tox-args }}

I'm not sure why this hash is needed, or if we can simply switch to v2 of that action.

We could also consider switching to the https://github.com/pyvista/setup-headless-display-action, which I think does the same (or similar) thing. @IgorTatarnikov has reported that it does the trick for brainglobe-stitch. We would have to compare that one to a more recent version of aganders3/headless-gui and check which ones best serves our needs.

@niksirbi niksirbi added the enhancement New feature or request label Mar 25, 2024
@alessandrofelder
Copy link
Member

AFAIK we now consistently use the pyvista alternative throughout BrainGlobe so I think switching to that would make sense (see e.g https://github.com/brainglobe/brainrender-napari/blob/d93447b5d1f5592aece2b39780442e7acbb7854f/.github/workflows/test_and_deploy.yml#L49)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants