-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unicode syntax #106
Conversation
I'm not really fond of adding unicode syntax to the plugin since it complicates the regexes quite a bit. It also does not end with highlighting, after highlighting works one needs to fix indentation to support it and indentation is already a hairy business. So I'm really reluctant to even consider this. Maybe as an optional feature but that would not prevent adding more conditional branches in the indentation in the future once this is introduced. So currently I'd say "No" on this one, even though you have put some effort into the patch. |
@raichoo So, you're about to close it and leave me to care about my own fork or you'd expect me to improve it and make this feature be optional? |
I'll probably leave this issue open for a while since others might want to chime in and maybe have some suggestions. I have a somewhat radical stance on unicode syntax in source code but maybe there are good reasons to support it which I haven't heard yet. For now I'd certainly would recommend that you maintain a fork. I hope this doesn't put you off regarding future contributions. |
@raichoo I have an idea, since I'm anyway maintaining my own repo for unicode support, how about adding another repo (e.g. |
Just a bump after about a year. |
@raichoo My proposal about separated repo is still valid. |
Shoot, wish I'd seen this PR before I ended up doing it myself; I actually didn't run into all that much difficulty with the regexes, as most all of the Unicode extensions don't touch too heavily on 'structural' parts of the language. Definitely a +1 to having this integrated if possible, though. |
@raichoo I seem to be not the only one who wants this feature. Here you can see @Achierius also struggled adding support for unicode being not aware this pull request exists, @DeCentN2Madness left a thumbs up reaction, and @mkohlhaas created similar merge request #134. Maybe worth considering to merge this? |
I myself still use my own fork for years now. |
I decided to maintain my own fork with Unicode syntax support that would be just a separate plugin from this one. The fork: https://github.com/wenzel-hoffman/haskell-with-unicode.vim @Achierius and @DeCentN2Madness, you can find this fork useful. I’m closing this merge request, since 2018 it wasn’t merged and and it seems it will never be. I also created a pull request with a change in README to point people who are looking for |
List of possible unicode operators may not be complete but could be extended later when needed.