Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude nodes with a specfic path not working as expected #22

Open
davidspiola opened this issue Aug 30, 2018 · 7 comments
Open

Exclude nodes with a specfic path not working as expected #22

davidspiola opened this issue Aug 30, 2018 · 7 comments

Comments

@davidspiola
Copy link
Contributor

General

In a multi site environment it would be very handy to be able to exclude nodes with a certain nodePath. This would give you the possibility to exclude entire sites from the redirect handler, what is perfectly fine somethings.

@dfeyer
Copy link
Contributor

dfeyer commented Sep 13, 2018

We can add this feature for sure 👍

@kdambekalns
Copy link
Member

While this is supposed to be working by now (as per #26), it only works for some cases… The "source path" is not the expected one, at least not for me:

  1. Having /sites/acmecom/imported set as "restricted"
  2. I have a node /sites/acmecom/imported/foo/bar
  3. I move that node to below /sites/acmecom/something

I expect no redirect to be created, but it is created. At the place the path is checked, the source is the new path of the mode to be published, not the old node path. The old URI is available at that point, but not the node path.

Fun fact: I already wondered about this back then… #26 (review)

@kdambekalns kdambekalns changed the title Exclude nodes with a specfic path Exclude nodes with a specfic path not working as expected Jul 10, 2019
@kdambekalns
Copy link
Member

A "workaround" for me is in #37 & #38

@Sebobo
Copy link
Member

Sebobo commented Aug 23, 2019

Can this now be assumed as resolved then?

@kdambekalns
Copy link
Member

Well, no. My case is solved by the new feature ("workaround"), but the original idea still makes sense.

@Sebobo
Copy link
Member

Sebobo commented Aug 23, 2019

But the new configuration allows excluding nodes by path. Isn't that what was requested?

@kdambekalns
Copy link
Member

But the new configuration allows excluding nodes by path. Isn't that what was requested?

Not really.

At the place the path is checked, the source is the new path of the mode to be published, not the old node path.

And the old node path simply isn't available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants