!!! TASK: Remove CheckpointStorageInterface #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the `CheckpointStorageInterface` and the `CatchUp` class (that relied upon it) from this package in order to keep this package focused on its main feature set. For 3rd parties that relied on this code, the [CatchUp](https://github.com/neos/eventstore/blob/bede780bd4e5f4d743ec6a9d4d9546df3c89206a/src/CatchUp/CatchUp.php) helper should be re-implemented for now. In the midterm, we plan to create a higher level package for projection and replay logic Resolves: #18
mhsdesign
approved these changes
Jan 12, 2024
bwaidelich
added a commit
to neos/neos-development-collection
that referenced
this pull request
Jan 21, 2024
Updates `neos/eventstore` and `neos/eventstore-doctrineadapter` packages to their first final release and adjusts code accordingly. Furthermore this incorporates the following changes: * Add `CheckpointStorageInterface` and its implementation `DbalCheckpointStorage` (aka `DoctrineCheckpointStorage`) from `neos/eventstore-doctrineadapter` (see neos/eventstore-doctrineadapter#13) * Add `CatchUp` from `neos/eventstore` (see neos/eventstore#19)
neos-bot
pushed a commit
to neos/contentgraph-doctrinedbaladapter
that referenced
this pull request
Jan 22, 2024
Updates `neos/eventstore` and `neos/eventstore-doctrineadapter` packages to their first final release and adjusts code accordingly. Furthermore this incorporates the following changes: * Add `CheckpointStorageInterface` and its implementation `DbalCheckpointStorage` (aka `DoctrineCheckpointStorage`) from `neos/eventstore-doctrineadapter` (see neos/eventstore-doctrineadapter#13) * Add `CatchUp` from `neos/eventstore` (see neos/eventstore#19)
neos-bot
pushed a commit
to neos/contentgraph-postgresqladapter
that referenced
this pull request
Jan 22, 2024
Updates `neos/eventstore` and `neos/eventstore-doctrineadapter` packages to their first final release and adjusts code accordingly. Furthermore this incorporates the following changes: * Add `CheckpointStorageInterface` and its implementation `DbalCheckpointStorage` (aka `DoctrineCheckpointStorage`) from `neos/eventstore-doctrineadapter` (see neos/eventstore-doctrineadapter#13) * Add `CatchUp` from `neos/eventstore` (see neos/eventstore#19)
neos-bot
pushed a commit
to neos/contentrepository-core
that referenced
this pull request
Jan 22, 2024
Updates `neos/eventstore` and `neos/eventstore-doctrineadapter` packages to their first final release and adjusts code accordingly. Furthermore this incorporates the following changes: * Add `CheckpointStorageInterface` and its implementation `DbalCheckpointStorage` (aka `DoctrineCheckpointStorage`) from `neos/eventstore-doctrineadapter` (see neos/eventstore-doctrineadapter#13) * Add `CatchUp` from `neos/eventstore` (see neos/eventstore#19)
neos-bot
pushed a commit
to neos/contentrepository-export
that referenced
this pull request
Jan 22, 2024
Updates `neos/eventstore` and `neos/eventstore-doctrineadapter` packages to their first final release and adjusts code accordingly. Furthermore this incorporates the following changes: * Add `CheckpointStorageInterface` and its implementation `DbalCheckpointStorage` (aka `DoctrineCheckpointStorage`) from `neos/eventstore-doctrineadapter` (see neos/eventstore-doctrineadapter#13) * Add `CatchUp` from `neos/eventstore` (see neos/eventstore#19)
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Jan 22, 2024
Updates `neos/eventstore` and `neos/eventstore-doctrineadapter` packages to their first final release and adjusts code accordingly. Furthermore this incorporates the following changes: * Add `CheckpointStorageInterface` and its implementation `DbalCheckpointStorage` (aka `DoctrineCheckpointStorage`) from `neos/eventstore-doctrineadapter` (see neos/eventstore-doctrineadapter#13) * Add `CatchUp` from `neos/eventstore` (see neos/eventstore#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
CheckpointStorageInterfaceand theCatchUpclass (that relied upon it) from this package in order to keep this package focused on its main feature set.For 3rd parties that relied on this code, the CatchUp helper should be re-implemented for now. In the midterm, we plan to create a higher level package for projection and replay logic
Resolves: #18