Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a single docker image for all components (for dockerhub) #12

Closed
neomatrix369 opened this issue Apr 4, 2022 · 11 comments · Fixed by #13
Closed

Create a single docker image for all components (for dockerhub) #12

neomatrix369 opened this issue Apr 4, 2022 · 11 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@neomatrix369
Copy link
Owner

neomatrix369 commented Apr 4, 2022

For learning and illustrating purposes it;s a good idea to have a single Docker image via single Dockerfile.

Then executing/implementing issues #1 to #10 will become easier. Thanks for splitting the issues into smaller parts @yugoccp

Here are two examples to follow to create the docker config file(s) and shell scripts to achieve it:

(also check the docker-image folder)

@neomatrix369 neomatrix369 added enhancement New feature or request good first issue Good for newcomers labels Apr 4, 2022
@neomatrix369
Copy link
Owner Author

@yugoccp let's do this together, I'll help you here, if we do it the above way there are multiple benefits

@neomatrix369 neomatrix369 changed the title Create a docker image for all components Create a single docker image for all components (for dockerhub) Apr 4, 2022
@yugoccp yugoccp self-assigned this Apr 10, 2022
@neomatrix369
Copy link
Owner Author

If there are any branches or PRs you wish reviewing feel free to push them to Github and I can share my comments on there.

@neomatrix369
Copy link
Owner Author

You are also a collaborator to this project which also means we can work on the same branch or PR if necessary @yugoccp

@neomatrix369
Copy link
Owner Author

Just enabled the https://github.com/neomatrix369/chatbot-conversations/projects/1 project management interface so that we can keep track of issues and PRs

@yugoccp
Copy link
Collaborator

yugoccp commented Apr 10, 2022

You are also a collaborator to this project which also means we can work on the same branch or PR if necessary @yugoccp

Thanks @neomatrix369 ! I'll push some changes soon!

@yugoccp
Copy link
Collaborator

yugoccp commented Apr 10, 2022

Created branch to address this issue
https://github.com/neomatrix369/chatbot-conversations/tree/feature/add-single-dockerfile

@neomatrix369 could you help me fix run container command?

@yugoccp
Copy link
Collaborator

yugoccp commented Apr 11, 2022

@neomatrix369 in the end I make it run with helidon and quarkus worlds, will be happy to review it together, and moving forward to also run roberta-world :)

@neomatrix369
Copy link
Owner Author

neomatrix369 commented Apr 11, 2022

I'll test it out on my machine and try to push something for python/roberta-world

Good work you made it work, would be great in the meanwhile we could write steps on how to use the shell scripts you wrote, I'm thinking we can use the same ideas from https://github.com/neomatrix369/awesome-ai-ml-dl/tree/master/examples/deepnetts#build-the-docker-container and https://github.com/neomatrix369/awesome-ai-ml-dl/tree/master/examples/deepnetts#run-the-deepnetts-docker-container

@neomatrix369
Copy link
Owner Author

@neomatrix369 in the end I make it run with helidon and quarkus worlds, will be happy to review it together, and moving forward to also run roberta-world :)

Its fixed now, there was an issue with torch==1.3.1 in the requirements.txt file, this version does not exist - check the commits you can see other changes as well.
I'll briefly test it and push the changes and let you continue

@neomatrix369
Copy link
Owner Author

There are some python related errors, try to debug and see why its failing - there is fun in this investigation.

@yugoccp
Copy link
Collaborator

yugoccp commented Apr 13, 2022

@neomatrix369 I've updated README.md file with instructions and fixed roberta-world dependency to work. Will open PR for review 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants