-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use non strict schema to allow some undefined behavior #2524
base: master
Are you sure you want to change the base?
Conversation
* GitHub Actions doesn't use the newer strict schema in the service * Tolerate more hallucinations
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
@jsoref What do you think? This appends an informal error if schema fails. I thought about adding strict validation after weak validation as warning, but the planner code doesn't have the context where the logger can be substituted... :( Docu update here: nektos/act-docs#32 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2524 +/- ##
===========================================
+ Coverage 61.56% 74.93% +13.36%
===========================================
Files 53 62 +9
Lines 9002 10013 +1011
===========================================
+ Hits 5542 7503 +1961
+ Misses 3020 1943 -1077
- Partials 440 567 +127 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsoref@jsoref-mbp winget-dsc % act --version
act version 0.2.69
jsoref@jsoref-mbp winget-dsc % act -l 2>&1|tail -3
Line: 37 Column 3: Failed to match on-sequence-strict: Line: 37 Column 3: Expected a sequence got mapping
Line: 37 Column 3: Failed to match on-mapping-strict: Line: 43 Column 5: Failed to match null: Line: 43 Column 5: Expected a scalar got mapping
Line: 43 Column 5: Failed to match pull-request-target-mapping: Line: 45 Column 5: Unknown Property tags-ignore
jsoref@jsoref-mbp winget-dsc % ~/code/nektos/act/dist/local/act --version
act version b253c5d
jsoref@jsoref-mbp winget-dsc % ~/code/nektos/act/dist/local/act -l
INFO[0000] Using docker host 'unix:///var/run/docker.sock', and daemon socket 'unix:///var/run/docker.sock'
WARN ⚠ You are using Apple M-series chip and you have not specified container architecture, you might encounter issues while running act. If so, try running it with '--container-architecture linux/amd64'. ⚠
Stage Job ID Job name Workflow name Workflow file Events
0 spelling Check Spelling Spell Checking spellCheck.yaml push,pull_request_target
1 comment-push Report (Push) Spell Checking spellCheck.yaml push,pull_request_target
1 comment-pr Report (PR) Spell Checking spellCheck.yaml pull_request_target,push
I was expecting to see an error message...
In theory, I like these changes, but..., for reasons I don't understand, I'm not seeing them.
The error level has been lowered. Custom properties in on are no failure anymore. |
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Provide Guidance