Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use non strict schema to allow some undefined behavior #2524

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChristopherHX
Copy link
Contributor

  • GitHub Actions doesn't use the newer strict schema in the service
  • Tolerate more hallucinations

Provide Guidance

* GitHub Actions doesn't use the newer strict schema in the service
* Tolerate more hallucinations
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.36s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.08s
✅ REPOSITORY secretlint yes no 1.08s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 4.32s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Nov 7, 2024

@jsoref What do you think?

This appends an informal error if schema fails.

I thought about adding strict validation after weak validation as warning, but the planner code doesn't have the context where the logger can be substituted... :(

Docu update here: nektos/act-docs#32

@ChristopherHX ChristopherHX marked this pull request as ready for review November 7, 2024 22:01
@ChristopherHX ChristopherHX requested a review from a team as a code owner November 7, 2024 22:01
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.93%. Comparing base (5a80a04) to head (be575d3).
Report is 128 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2524       +/-   ##
===========================================
+ Coverage   61.56%   74.93%   +13.36%     
===========================================
  Files          53       62        +9     
  Lines        9002    10013     +1011     
===========================================
+ Hits         5542     7503     +1961     
+ Misses       3020     1943     -1077     
- Partials      440      567      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsoref@jsoref-mbp winget-dsc % act --version
act version 0.2.69
jsoref@jsoref-mbp winget-dsc % act -l 2>&1|tail -3
Line: 37 Column 3: Failed to match on-sequence-strict: Line: 37 Column 3: Expected a sequence got mapping
Line: 37 Column 3: Failed to match on-mapping-strict: Line: 43 Column 5: Failed to match null: Line: 43 Column 5: Expected a scalar got mapping
Line: 43 Column 5: Failed to match pull-request-target-mapping: Line: 45 Column 5: Unknown Property tags-ignore
jsoref@jsoref-mbp winget-dsc % ~/code/nektos/act/dist/local/act --version
act version b253c5d
jsoref@jsoref-mbp winget-dsc % ~/code/nektos/act/dist/local/act -l
INFO[0000] Using docker host 'unix:///var/run/docker.sock', and daemon socket 'unix:///var/run/docker.sock'
WARN  ⚠ You are using Apple M-series chip and you have not specified container architecture, you might encounter issues while running act. If so, try running it with '--container-architecture linux/amd64'. ⚠
Stage  Job ID        Job name        Workflow name   Workflow file    Events
0      spelling      Check Spelling  Spell Checking  spellCheck.yaml  push,pull_request_target
1      comment-push  Report (Push)   Spell Checking  spellCheck.yaml  push,pull_request_target
1      comment-pr    Report (PR)     Spell Checking  spellCheck.yaml  pull_request_target,push

I was expecting to see an error message...

In theory, I like these changes, but..., for reasons I don't understand, I'm not seeing them.

pkg/model/workflow.go Outdated Show resolved Hide resolved
@ChristopherHX
Copy link
Contributor Author

for reasons I don't understand, I'm not seeing them.

The error level has been lowered. Custom properties in on are no failure anymore.

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants