Consider publishing to homebrew? #95
Comments
|
It’s not something I have considered, I tend to view homebrew as being for terminal applications.
By all means have a go, I don’t have an issue with this and would merge in any required changes required for deployment using homebrew.
Adrian
…On 3 Mar 2022, 21:35 +0000, Callum Macdonald ***@***.***>, wrote:
I was searching for ping apps on homebrew but didn't find pingnoo there, found it via alternativeto.net instead.
Would you be open to publishing on homebrew? I can lend a hand if that helps, I've tried (and failed) to help joplin publish to homebrew. But hopefully pingnoo would be simpler. :-)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Awesome. I think it would also require an extra step when every version is released to tell brew about the new version. Brew is traditionally for command line applications and then they call regular applications "casks". I'm used to installing (and updating) most of my free software through brew. Makes it easy to track updates across my whole system. |
|
There is a deployment script as part of the pingnoo, it’s responsible for creating the various “packages” for the application across different operating systems.
Under Linux, it creates AppImage, Debian packages, RPM’s and so on, it also publishes the package where necessary, for example under arch it uploads the appropriate file the arch package manager.
It’s all automated because it’s a nightmare trying to support all these different systems, with a script it handles it all, it’s repeatable.
I use teamcity to create the builds, it compiles and packages up every single platform distribution in one hit, I press a button and magically everything appears in the right places after a while.
Adrian
…On 3 Mar 2022, 22:11 +0000, Callum Macdonald ***@***.***>, wrote:
Awesome. I think it would also require an extra step when every version is released to tell brew about the new version.
Brew is traditionally for command line applications and then they call regular applications "casks". I'm used to installing (and updating) most of my free software through brew. Makes it easy to track updates across my whole system.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Ok, I submitted a PR to add the cask Homebrew/homebrew-cask#120000 To update, the version parameter in the Also, I assumed that the "latest" version is the one tagged "Latest" on GitHub and not what the website downloads. I setup a version check in the cask file based on that assumption also. #96 |
|
Cheers. I will have a look over the weekend.
If you look inside the deploy.py you will see how it builds, packages and publishes the various releases to the repos.
Look at the AUR one as I believe this is almost certainly does what you need.
The past 8-10 months I have been really unwell, so I haven’t managed to do too much on it, but, it’s pretty usable as it stands. I have just started adding in the clipboard code, so that you can cut and paste the data easily and use it elsewhere, so there are things like copy as pdf, copy as image, copy as text and so on.
I think at that point it will become really useful.
Adrian
…On 4 Mar 2022, 07:33 +0000, Callum Macdonald ***@***.***>, wrote:
Ok, I submitted a PR to add the cask Homebrew/homebrew-cask#120000
To update, the version parameter in the Casks/pingnoo.rb file in the homebrew-cask repo needs to be updated and then the new sha256 value for the new .dmg file also updated. I'm not really sure how you would automate this process within your teamcity process as I'm not familiar with it. Is that something you could look into (assuming that the cask is accepted)?
Also, I assumed that the "latest" version is the one tagged "Latest" on GitHub and not what the website downloads. I setup a version check in the cask file based on that assumption also. #96
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Sorry to hear you've been unwell. Let's see if brew accept the cask. It should be fairly easy to document how to update the cask, but the method requires opening a PR on GitHub, so I guess that it's probably easier to do it manually rather than try and script it. |
|
Some feedback on the PR, we're hitting an issue with the versioning, not sure what the solution will be, but will report back. |
|
Okay, I think everything has been sorted out and the PR should land. So that'll put the current "Latest" version from GitHub into brew. In theory, to release a new version to homebrew, you'll need to open a Pull Request against the |
|
It needs to be automated, because it’s really time consuming doing anything release related by hand, it’s also very tedious.
Generating PR or pretty much anything on GitHub is very easy to automate for this specific reason, there is already stuff inside the deployment script which uses the GitHub API to create the release and uploads of the assets.
https://docs.github.com/en/rest/reference/pulls
I will take a look as soon as I can.
Adrian
…On 8 Mar 2022, 20:39 +0000, Callum Macdonald ***@***.***>, wrote:
Okay, I think everything has been sorted out and the PR should land. So that'll put the current "Latest" version from GitHub into brew. In theory, to release a new version to homebrew, you'll need to open a Pull Request against the homebrew-cask repo which updates the version and sha256 values in the Casks/pingnoo.rb file. I'd assume that it's simpler to do that by hand than it is to automate it, especially the part about opening a PR, I guess that's hard to script. What do you think?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Fair enough, totally up to you. I think the steps are:
The pull request has a format, and there's a series of tasks which should be completed. Like running |
|
That looks easy enough. Leave it with me. Bump me over the weekend if I haven’t done it!
Adrian
…On 9 Mar 2022, 09:20 +0000, Callum Macdonald ***@***.***>, wrote:
Fair enough, totally up to you.
I think the steps are:
• Fork the homebrew-cask repo
• Create a new branch
• Update the version and sha256 values in Casks/pingnoo.rb
• version gets the latest version string
• sha256 gets the sha256 value of the .dmg file
• Commit
• Create a pull request
The pull request has a format, and there's a series of tasks which should be completed. Like running brew audit and other commands. But there's also a load of checks run when you open the PR. I'm not sure how you'd want to approach that, whether you run all those tasks and then update the PR body, or write some code to check that the tasks haven't changed, etc. Here's the current text of the new PR template:
**Important:** *Do not tick a checkbox if you haven’t performed its action.* Honesty is indispensable for a smooth review process.
_In the following questions `<cask>` is the token of the cask you're submitting._
After making all changes to a cask, verify:
- [ ] The submission is for [a stable version](https://docs.brew.sh/Acceptable-Casks#stable-versions) or [documented exception](https://docs.brew.sh/Acceptable-Casks#but-there-is-no-stable-version).
- [ ] `brew audit --cask <cask>` is error-free.
- [ ] `brew style --fix <cask>` reports no offenses.
Additionally, **if adding a new cask**:
- [ ] Named the cask according to the [token reference](https://docs.brew.sh/Cask-Cookbook#token-reference).
- [ ] Checked the cask was not [already refused](https://github.com/Homebrew/homebrew-cask/search?q=is%3Aclosed&type=Issues).
- [ ] Checked the cask is submitted to [the correct repo](https://docs.brew.sh/Acceptable-Casks#finding-a-home-for-your-cask).
- [ ] `brew audit --new-cask <cask>` worked successfully.
- [ ] `brew install --cask <cask>` worked successfully.
- [ ] `brew uninstall --cask <cask>` worked successfully.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Btw, I just saw a PR which said "Created with brew |
I was searching for ping apps on homebrew but didn't find pingnoo there, found it via alternativeto.net instead.
Would you be open to publishing on homebrew? I can lend a hand if that helps, I've tried (and failed) to help joplin publish to homebrew. But hopefully pingnoo would be simpler. :-)
The text was updated successfully, but these errors were encountered: