Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participant groups feature #881

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

dodumosu
Copy link
Collaborator

@dodumosu dodumosu commented Apr 8, 2022

this PR adds support for participant groups.

it also adds the text/plain mimetype for CSV imports.

@dodumosu dodumosu requested a review from takinbo April 8, 2022 08:06
@dodumosu
Copy link
Collaborator Author

dodumosu commented Jul 2, 2022

Added filtering submissions and the dashboard (when conflicts tracking is disabled in the latter case) by participant groups

@takinbo
Copy link
Collaborator

takinbo commented Jul 5, 2022

I've checked all the screens where this widget is supposed to be displayed and they all look adequately sized. There are only two nits that need to be resolved:

  1. In all places where you've used "All Participant Groups" simply use "Participant Groups"
  2. The styling of the widget needs to be consistent with the others. See screenshot below.

D53D002F-E3D7-426E-BA3A-E9AEEB0463E1

@dodumosu
Copy link
Collaborator Author

dodumosu commented Jul 6, 2022

the text has been changed, but regarding the second point, perhaps you can specify the exact styles you want applied? i've already tried a number of styles from different templates for the select2 widgets and none of them look any different to me.

this commit changes the empty label for location group filter fields
to a localized translation of "Location Group"
it also adds an empty label for participant group filter fields and
makes it single-choice, not multiple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants