perf:rebuild camera loop,light #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat:import Perf
KusStar
reviewed
Jul 6, 2023
There was a problem hiding this comment.
原项目使用了 yarn(.lock)，说明你也应该使用 yarn，不应该再引入一个 pack-lock.json
There was a problem hiding this comment.
原项目使用了 yarn(.lock)，说明你也应该使用 yarn，不应该再引入一个 pack-lock.json
好的
KusStar
reviewed
Jul 6, 2023
Comment on lines
+36
to
+47
| // const alpha = 0.1; | ||
| // state.camera.position.lerp( | ||
| // new THREE.Vector3(camPos.x, camPos.y, camPos.z), | ||
| // alpha | ||
| // ); | ||
| // lookAtPos.lerp(new THREE.Vector3(lookAt.x, lookAt.y, lookAt.z), alpha); | ||
| // state.camera.lookAt( | ||
| // new THREE.Vector3(lookAtPos.x, lookAtPos.y, lookAtPos.z) | ||
| // ); | ||
| // state.camera.updateProjectionMatrix(); | ||
| // if (state.clock.getElapsedTime() > 1.2) setAnimation(false); | ||
| // }); |
There was a problem hiding this comment.
不需要的代码自己删掉就行，不需要以注释的方式保留
了解
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:import Perf