Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Distributions don't work as expected #123

Open
3 of 5 tasks
ChrisJones687 opened this issue Dec 18, 2020 · 0 comments
Open
3 of 5 tasks

Multiple Distributions don't work as expected #123

ChrisJones687 opened this issue Dec 18, 2020 · 0 comments
Assignees
@ChrisJones687
Labels
bug Something isn't working

Comments

@ChrisJones687
Copy link
Member

ChrisJones687 commented Dec 18, 2020 •
edited
Loading

There are 5 distributions that don't work as intended:

  • Gamma (doesn't solve the CDF if value >15)
  • Log-Normal (crashes with values of a sigma > 5)
  • Power Law (doesn't disperse outside of the original cell)
  • Logistic (isn't in Radial Kernel)
  • Exponential Power (doesn't disperse outside of the original cell)
@ChrisJones687 ChrisJones687 added the bug Something isn't working label Dec 18, 2020
@ChrisJones687 ChrisJones687 added this to the 1.1.0 milestone Dec 18, 2020
@ChrisJones687 ChrisJones687 self-assigned this Dec 18, 2020
ChrisJones687 added a commit that referenced this issue Dec 18, 2020
@ChrisJones687
swapped shape and scale parameter in power law distribution call. fix…
fc47e4d 
…es power law distribution in #123
ChrisJones687 added a commit that referenced this issue Apr 3, 2021
@ChrisJones687 @malawrim
Fix 123 (#124)
f715f27 
* Fixed call to logistic kernel in exp_power

now exponential power kernel is found and logistic kernel works as intended

* correct power law CDF

* swapped shape and scale parameter in power law distribution call. fixes power law distribution in #123

* simplified PDF and removed - in exp.

* simplified log normal cdf using erf function.

* revert cdf for tests

* add negative in lognormal PDF

* revert cdf

* simplified cdf using complimentary error function

* fixed missing semicolon

* Adding/updated tests and changing gamma.cdf

added tests to test_deterministic

Fixing gamma kernel call

reverting log normal for gamma tests

removing line in gamma

fixing problem in deterministic test

fix problem in exponential power

adding tests for log normal

* updated approximation for inverse erf

* updated results for power law tests

* updated power law test results

* updated formula for exponential_power.icdf

updated inverse erf approximation in normal

* updated exponential power test

* fixing error in exponential power test

* updating gamma kernel icdf

* fixed error in gamma kernel

* Update test_deterministic.cpp

* Update radial_kernel.hpp

revert power-law call back to distance then shape.

Co-authored-by: MargaretLawrimore <margaret.lawrimore@gmail.com>
@ChrisJones687 ChrisJones687 modified the milestones: 1.1.0, 1.3 May 14, 2021
@ChrisJones687 ChrisJones687 removed this from the 1.3.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisJones687 ChrisJones687

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisJones687 @malawrim