Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action to check for no newline at the end of file #117

Open
wenzeslaus opened this issue Sep 30, 2020 · 1 comment
Open

Add GitHub Action to check for no newline at the end of file #117

wenzeslaus opened this issue Sep 30, 2020 · 1 comment
Labels
CI Continuous integration enhancement New feature or request good first issue Good for newcomers

Comments

@wenzeslaus
Copy link
Member

clang-format does not check for the newline at the end of file leaving this on editors or Git. GitHub nicely shows a warning for that, so to make code warning free, use https://github.com/marketplace/actions/linelint
@wenzeslaus wenzeslaus added enhancement New feature or request good first issue Good for newcomers CI Continuous integration labels Sep 30, 2020
@wenzeslaus wenzeslaus mentioned this issue Sep 30, 2020
Merged
@wenzeslaus
Copy link
Member Author

Maybe migrate to new clang-format first to see if a separate check is still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wenzeslaus