Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Interaction Feature — Add node to existing polygon #142

Open
gcmillar opened this issue Feb 19, 2021 · 1 comment
Open

Proposed Interaction Feature — Add node to existing polygon #142

gcmillar opened this issue Feb 19, 2021 · 1 comment
Assignees
Labels
UI/UX PoPS UI — Notes — Needed Fixes

Comments

@gcmillar
Copy link

Proposed Interaction Feature — Add node to existing polygon - then be able to move / edit its placement

mapbox
@gcmillar gcmillar changed the title Propose Interaction Feature — Add node to existing polygon Proposed Interaction Feature — Add node to existing polygon Feb 19, 2021
@gcmillar gcmillar added the UI/UX PoPS UI — Notes — Needed Fixes label Feb 19, 2021
@gcmillar gcmillar self-assigned this Feb 19, 2021
@shannonkjones
Copy link
Member

This functionality is not supported in mapbox-gl-draw. We could write our own custom functionality (for example, I created the circle tool), but you'd have to think very carefully about how to implement it.

  1. How to differentiate drawing a new point on the existing polygon VS drawing a first point on a new polygon.
  2. Differentiating drawing a new point on the polygon VS selecting the polygon VS moving the polygon.
  3. Would probably need a new 'add point' tool, that could only create a single point. Then there is the additional complication of knowing HOW to integrate the point. Adding of the 4th point in your example could easily end up looking like a 'bow tie' rather than a rectangle. You could rely on the user to then fix it to be the shape they wanted (but if they have to do that, then they might as well delete the original shape and draw what they want). Otherwise, there would have to be some math (perhaps not too terribly complicated) to figure out the most probable way the user intended for the point to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX PoPS UI — Notes — Needed Fixes
Projects
None yet
Development

No branches or pull requests

2 participants