Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency version pinning discussion #748

Closed
tennlee opened this issue Nov 17, 2024 · 2 comments
Closed

Dependency version pinning discussion #748

tennlee opened this issue Nov 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tennlee
Copy link
Collaborator

tennlee commented Nov 17, 2024

During the release process of the last release, I inadvertently (but harmlessley) dropped the version pinning from the released version. This is not a major issue since we support a very wide range of versions of things, and are up-to-date, so I propose to bring it back in the next release rather than issuing a hurried patch.

One factor in this was having a differences in pyproject.toml between 'main' and 'develop'. An alternative would be to have a separate variant for releases and development. This would require developers to use pip install -e .[dev] when working on the package, which doesn't seem like a difficult change. If they failed to do so, it's also unlikely there would be any real problems as the CI/CD would repeat testing on the latest versions of things, which would still allow the package to be kept up to date easily.

If anyone has any comment on the current release or this change, please feel free to leave it here, and I will take it into account when planning the next release.

@Steph-Chong
Copy link
Collaborator

A quick suggestion - once an approach is chosen, I would suggest adding a note in the maintainers notes documentation (somewhere in here: https://scores.readthedocs.io/en/stable/maintainer.html#this-section-covers-the-process-for-making-a-release-from-the-develop-branch) about ensuring correct version pinning before the release - simply to reduce the likelihood of this reoccurring.

@tennlee tennlee self-assigned this Nov 22, 2024
@tennlee tennlee added the enhancement New feature or request label Nov 22, 2024
@tennlee
Copy link
Collaborator Author

tennlee commented Nov 27, 2024

Fixed by #760
Pinned versions are now set during the hatch build process for the release packaging.

@tennlee tennlee closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants