Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntEnum for treenode-connector relationships #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

clbarnes
Copy link
Collaborator

@clbarnes clbarnes commented Jul 6, 2023

I can never remember these and it drives me spare trying to find them in code.

Does this lean too heavily into the CATMAID data model? Navis already uses the 0 and 1 for presynapse/postsynapse but I don't know if you use any of the other types. Alternatively, there could be a cut-down version here and the full one in pymaid (slightly more complicated than just re-exporting this enum from pymaid but not too bad).

@schlegelp
Copy link
Collaborator

navis has so far tried to not play favourites but CATMAID has the only well defined connector data model that I've come across. Perhaps (Web)Knossos has one too but I haven't dug into it.

I like your proposal to formalise the data model for navis. May need a bit of time to mull it over - for example also thinking about whether/how to re-use this for plotting too.

@clbarnes
Copy link
Collaborator Author

clbarnes commented Jul 28, 2023

I've cut this down to just the pre/post synapse relations, which I think is all navis already uses, as well as adding some really explicit methods for what the relation means for the node and the connector, because it ties my brain in knots every time I have to deal with it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants