You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To combat future additional copy pasta, I think we should make the following housekeeping changes to the integration tests:
Move all set_fact items to main.yml (protip: tag always). This will make it obvious what fact names are already in use and which ones might be conflicting.
Move all version conditional blocks (for full test suites) to main.yml. This should help make it obvious which tests should run for each minimum version. Any conditional blocks within files for only a sub-set of tasks can remain to keep the tests together.
Remove all erroneous debug tasks.
The text was updated successfully, but these errors were encountered:
joewesch
changed the title
Integration housekeeping
Integration tests housekeeping
Nov 20, 2024
To combat future additional copy pasta, I think we should make the following housekeeping changes to the integration tests:
set_fact
items tomain.yml
(protip: tagalways
). This will make it obvious what fact names are already in use and which ones might be conflicting.main.yml
. This should help make it obvious which tests should run for each minimum version. Any conditional blocks within files for only a sub-set of tasks can remain to keep the tests together.debug
tasks.The text was updated successfully, but these errors were encountered: