Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests housekeeping #452

Open
joewesch opened this issue Nov 20, 2024 · 0 comments
Open

Integration tests housekeeping #452

joewesch opened this issue Nov 20, 2024 · 0 comments

Comments

@joewesch
Copy link
Contributor

To combat future additional copy pasta, I think we should make the following housekeeping changes to the integration tests:

  • Move all set_fact items to main.yml (protip: tag always). This will make it obvious what fact names are already in use and which ones might be conflicting.
  • Move all version conditional blocks (for full test suites) to main.yml. This should help make it obvious which tests should run for each minimum version. Any conditional blocks within files for only a sub-set of tasks can remain to keep the tests together.
  • Remove all erroneous debug tasks.
@joewesch joewesch changed the title Integration housekeeping Integration tests housekeeping Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant