Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin coverage or rip it out? #136

Open
gsnider2195 opened this issue Aug 7, 2024 · 1 comment
Open

Pin coverage or rip it out? #136

gsnider2195 opened this issue Aug 7, 2024 · 1 comment
Milestone

Comments

@gsnider2195
Copy link
Contributor

Nautobot core pinned coverage to 6.4.0 to resolve nedbat/coveragepy#1420 that is breaking pdb breakpoints, making debugging difficult or impossible. We need to consider pinning this here and/or removing coverage from the development environment altogether and running it in CI instead. Coverage significantly slows down unit testing and most other projects only run it in their pull request CI.

@cmsirbu
Copy link
Contributor

cmsirbu commented Aug 7, 2024

Looking at this I've noticed the issue has not had any activity in a year, so a fix is nowhere near seemingly. To top it off, 6.4.0 was released in 2022, so it is not compatible with python 3.12+ and pinning it will start creating problems. My inclination is to yeet it into PR CI only and out of the devenv.

Perhaps if we can make the coverage results more visible in a PR? Is that some other type of integration?

@cmsirbu cmsirbu added this to the v2.4.0 milestone Aug 7, 2024
@cmsirbu cmsirbu modified the milestones: v2.4.0, v2.5.0 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants