[DRAFT] Raft Improvements #5951
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenMathew
force-pushed
the
rmn/raft-improvements
branch
from
b8fd361
to
40ed4da
Compare
ReubenMathew
force-pushed
the
rmn/raft-improvements
branch
from
40ed4da
to
466aa73
Compare
server/raft.go
Outdated
| @@ -3619,6 +3613,17 @@ func (n *raft) processAppendEntryResponse(ar *appendEntryResponse) { | |||
| n.stepdownLocked(noLeader) | |||
| n.Unlock() | |||
| arPool.Put(ar) | |||
| return | |||
| } else if ar.term < n.term { | |||
There was a problem hiding this comment.
Don't need this else, just normal if here since you return from the previous block.
ReubenMathew
force-pushed
the
rmn/raft-improvements
branch
from
466aa73
to
11dd1f6
Compare
|
@ReubenMathew it would be helpful to share a short summary of what the change addresses. |
Signed-off-by: reubenninan <reuben@nats.io>
No need to set term if granting vote since receiving a request with a higher or lower term is handled earlier in this method. Signed-off-by: reubenninan <reuben@nats.io>
ReubenMathew
force-pushed
the
rmn/raft-improvements
branch
from
6373dd5
to
4b77836
Compare
I am still chewing on one of the changes; the one related to AppendEntries response handling is theoretically correct, but it's breaking a lot of unit tests. There's some behavior I'm not accounting for... I will update the PR and take it out of draft when I figure it out. |
Signed-off-by: reubenninan <reuben@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT