Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voices aren't scheduled immediately, so some audio is missed. #22

Open
nathanleiby opened this issue Nov 7, 2024 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@nathanleiby
Copy link
Owner

nathanleiby commented Nov 7, 2024

It takes a few beats before you hear sounds because of schedule ahead logic

Examples:

  • Change the loop (including first run).. press play.. its sounds aren't scheduled yet.
  • Click change a single beat, the voices aren't scheduled immediately.

Today, audio scheduling happens "just in time" as the clock progresses, but perhaps it should also depend on when notes are added/removed.

Relatedly, we might want to track handles for all scheduled sounds so we can unschedule them before/during play if they're removed

let handle = manager.play(sound.with_settings(sound_settings))?;
// track the handles...
// if need to stop...
handle.stop()
@nathanleiby nathanleiby added bug Something isn't working enhancement New feature or request labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant