Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed minimum version to 3.18 #3021

Closed
wants to merge 1 commit into from

Conversation

rithvikrajraapeti
Copy link

@rithvikrajraapeti rithvikrajraapeti commented Nov 12, 2024

Related Issue(s) changing the cmake minimum version to be 3.18
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

changed the minimum version to 3.18

Future Work

Note any additional work that will be done relating to this issue.

@LeStarch
Copy link
Collaborator

@rithvikrajraapeti what specifically caused the need for this change? Is CMake 3.16 causing issues here?

@rithvikrajraapeti
Copy link
Author

For me it didnt run properly

@rithvikrajraapeti
Copy link
Author

And even the version is outdated and it may cause some issues

@rithvikrajraapeti
Copy link
Author

And its only considring the .cpp files and not the .h files if i added it

@rithvikrajraapeti
Copy link
Author

Only for me

@rithvikrajraapeti
Copy link
Author

And i saw this issue and this is common and you can change the version to 1.18

@rithvikrajraapeti
Copy link
Author

and what happend to a test

@LeStarch
Copy link
Collaborator

We haven't seen this failure in our side. To fix this in a project, it is best to add that statement to the top of your project CMakeLists.txt.

If there is still an issue, please post the error you received and we can help debug. For now we are hesitant to up the minimum version for all users until we see a concrete error with it.

@LeStarch LeStarch closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants