Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Google Drive Node): Replace the description of the 'Can Share' capability in Google Drive (no-changelog) #11827

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

imchairmanm
Copy link
Contributor

Summary

The current description of the canShare capability when creating a new Google Drive is reusing the string from canRenameDrive. This commit updates it to refer to sharing capabilities.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

The current description of the `canShare` capability when creating a new
Google Drive is reusing the string from `canRenameDrive`. This commit
updates it to refer to sharing capabilities.
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏻

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 22, 2024

n8n    Run #8045

Run Properties:  status check passed Passed #8045  •  git commit 0f68361749: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 imchairmanm 🗃️ e2e/*
Project n8n
Branch Review fix_typo_in_gdrive
Run status status check passed Passed #8045
Run duration 04m 29s
Commit git commit 0f68361749: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 imchairmanm 🗃️ e2e/*
Committer Justin Ellingwood
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@Joffcom Joffcom merged commit 96e6be7 into master Nov 28, 2024
35 checks passed
@Joffcom Joffcom deleted the fix_typo_in_gdrive branch November 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants