Support dkms when it is not in PATH #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows CMake configuration to detect that dkms command is not in the current PATH. This happens on some Linux systems which do no add /usr/sbin to all users, even if they are part of sudo/wheel. For example, this is default Raspbian OS onfiguration. CMake's find_program() allows to detect dkms command when it is in /usr/sbin but not in the current PATH. The code block which runs dkms command is still kept, so that if the dkms is uninstalled, CMake configuration adopts to it. It could be removed in the future, but for now the idea was to minimize impact this change is bringing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows CMake configuration to detect that dkms command is not in the current PATH. This happens on some Linux systems which do no add /usr/sbin to all users, even if they are part of sudo/wheel. For example, this is default Raspbian OS onfiguration.
CMake's find_program() allows to detect dkms command when it is in /usr/sbin but not in the current PATH.
The code block which runs dkms command is still kept, so that if the dkms is uninstalled, CMake configuration adopts to it. It could be removed in the future, but for now the idea was to minimize impact this change is bringing.