Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.critical() should not be needed when fail-fast strategy is used #48

Open
bakatz opened this issue Nov 26, 2019 · 1 comment
Open

.critical() should not be needed when fail-fast strategy is used #48

bakatz opened this issue Nov 26, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bakatz
Copy link

bakatz commented Nov 26, 2019

It seems strange to require .critical() on each rule when failfast is already enabled - just wanted to file a suggestion to consider changing this design to not require the extra .critical() call

Side note: nice work on this library. This is the best alternative to FluentValidation (.NET library) that I've found for java. Thanks!

@mvallim mvallim self-assigned this Nov 26, 2019
@mvallim mvallim added the enhancement New feature or request label Nov 26, 2019
@mvallim
Copy link
Owner

mvallim commented Nov 27, 2019

Hi @bakatz,

It makes sense to say that making the critical statement less verbose when failFastRule is enabled.

I will work on this issue and the next release will be available.

Thanks for the feeback, I really appreciate it!

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants