-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace basic authentication with credentials authentication provider #3136
base: master
Are you sure you want to change the base?
Conversation
f12f71d
to
eecfa72
Compare
eecfa72
to
f12f71d
Compare
f12f71d
to
045ba91
Compare
As per last grooming meeting:
|
Looks like that even if I whitelist requests from iframes, which are all being blocked by the auth middleware right now, the CSRF protection doesn't allow the sign-in to work from a different domain. Maybe I could get around it by removing the same-site headers in the cookies Auth.js sets but that's less secure... |
We don't have to merge this one as not sure if it's a good idea and apparently the current basic authentication works well on iframes but this one might not work as well? Anyway the idea is here, if we close it it's ok.
We also don't necessarily have to remove the previous basic authentication, these features could coexist...
As has been briefly discussed before, here's how we could replace our current basic authentication feature with using the new authentication features, with a "Credentials" authentication provider that I already had to set up for authentication tests anyway.
Screen.Recording.2024-01-26.at.12.33.27.mov