[charts] Fix hydration missmatch #15647
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
bug 🐛
|
Deploy preview: https://deploy-preview-15647--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #15647 will degrade performances by 27.32%Comparing Summary
Benchmarks breakdown
|
|
This change weirdly affects a lot of performance. I guess because it has to re-render to get an actual chartId? 🤔 |
flaviendelangle
approved these changes
Nov 28, 2024
alexfauquette
force-pushed
the
fix-id-missmatch
branch
from
2c26aa2
to
b523592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small issue I introduced when moving to plugins