tiny updates in the dev/RecordRTC.promises.js

muaz-khan · Jan 13, 2019 · 5dd23a8 · 5dd23a8
1 parent e5147b7
commit 5dd23a8
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 17 deletions.
diff --git a/RecordRTC.js b/RecordRTC.js
@@ -1,9 +1,9 @@
 'use strict';
 
-// Last time updated: 2019-01-11 12:28:08 PM UTC
+// Last time updated: 2019-01-13 11:46:56 AM UTC
 
 // ________________
-// RecordRTC v5.5.1
+// RecordRTC v5.5.2
 
 // Open-Sourced: https://github.com/muaz-khan/RecordRTC
 
@@ -773,7 +773,7 @@ function RecordRTC(mediaStream, config) {
          * @example
          * alert(recorder.version);
          */
-        version: '5.5.1'
+        version: '5.5.2'
     };
 
     if (!this) {
@@ -791,7 +791,7 @@ function RecordRTC(mediaStream, config) {
     return returnObject;
 }
 
-RecordRTC.version = '5.5.1';
+RecordRTC.version = '5.5.2';
 
 if (typeof module !== 'undefined' /* && !!module.exports*/ ) {
     module.exports = RecordRTC;
@@ -5541,6 +5541,12 @@ function RecordRTCPromisesHandler(mediaStream, options) {
             try {
                 self.recordRTC.stopRecording(function(url) {
                     self.blob = self.recordRTC.getBlob();
+
+                    if (!self.blob || !self.blob.size) {
+                        reject('Empty blob.', self.blob);
+                        return;
+                    }
+
                     resolve(url);
                 });
             } catch (e) {
@@ -5578,11 +5584,17 @@ function RecordRTCPromisesHandler(mediaStream, options) {
      * @memberof RecordRTCPromisesHandler
      * @example
      * recorder.stopRecording().then(function() {
-     *     var blob = recorder.getBlob();
+     *     recorder.getBlob().then(function(blob) {})
      * }).catch(errorCB);
      */
     this.getBlob = function() {
-        return self.recordRTC.getBlob();
+        return new Promise(function(resolve, reject) {
+            try {
+                resolve(self.recordRTC.getBlob());
+            } catch (e) {
+                reject(e);
+            }
+        });
     };
 
     /**

diff --git a/RecordRTC.min.js b/RecordRTC.min.js
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "recordrtc",
-  "version": "5.5.1",
+  "version": "5.5.2",
   "authors": [
         {
             "name": "Muaz Khan",

diff --git a/dev/RecordRTC.promises.js b/dev/RecordRTC.promises.js
@@ -74,6 +74,12 @@ function RecordRTCPromisesHandler(mediaStream, options) {
             try {
                 self.recordRTC.stopRecording(function(url) {
                     self.blob = self.recordRTC.getBlob();
+
+                    if (!self.blob || !self.blob.size) {
+                        reject('Empty blob.', self.blob);
+                        return;
+                    }
+
                     resolve(url);
                 });
             } catch (e) {
@@ -111,11 +117,17 @@ function RecordRTCPromisesHandler(mediaStream, options) {
      * @memberof RecordRTCPromisesHandler
      * @example
      * recorder.stopRecording().then(function() {
-     *     var blob = recorder.getBlob();
+     *     recorder.getBlob().then(function(blob) {})
      * }).catch(errorCB);
      */
     this.getBlob = function() {
-        return self.recordRTC.getBlob();
+        return new Promise(function(resolve, reject) {
+            try {
+                resolve(self.recordRTC.getBlob());
+            } catch (e) {
+                reject(e);
+            }
+        });
     };
 
     /**

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "recordrtc",
   "preferGlobal": false,
-  "version": "5.5.1",
+  "version": "5.5.2",
   "author": {
     "name": "Muaz Khan",
     "email": "muazkh@gmail.com",

diff --git a/simple-demos/RecordRTCPromisesHandler.html b/simple-demos/RecordRTCPromisesHandler.html
@@ -30,10 +30,11 @@ <h1>Promises and RecordRTC</h1>
 
 function stopRecordingCallback() {
     video.srcObject = null;
-    var blob = recorder.getBlob();
-    video.src = URL.createObjectURL(blob);
-
-    recorder.camera.stop();
+
+    recorder.getBlob().then(function(blob) {
+        video.src = URL.createObjectURL(blob);
+        recorder.camera.stop();
+    });
 }
 
 var recorder; // globally accessible