Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize thumbnail to requested size #2

Open
mttbernardini opened this issue May 3, 2021 · 2 comments
Open

Resize thumbnail to requested size #2

mttbernardini opened this issue May 3, 2021 · 2 comments

Comments

@mttbernardini
Copy link
Owner

In the gnome thumbnailing system, the requested size for a thumbnail is passed with the %s placeholder (see /resources/appimage-thumbnailer.thumbnailer). The gnome thumbnailer should honor the argument and resize .DirIcon to the requested size.

In the kde thumbnailing system, the requested size for a thumbnail is passed with arguments witdht and height. QImage provides a method (scaled) for resizing the icon.
@mttbernardini
Copy link
Owner Author

Partially fixed in 5ce5459 for KDE.

GNOME can't be fixed because of #3

@mttbernardini
Copy link
Owner Author

An additional note: it would be smarter to check if there's an appropriate icon under ./usr/share/icon/hicolor satisfying the target size, rather than always resizing .DirIcon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mttbernardini