Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSK Update #57

Closed
wants to merge 4 commits into from
Closed

DSK Update #57

wants to merge 4 commits into from

Conversation

rstad
Copy link
Contributor

@rstad rstad commented Sep 26, 2024

  1. Updated cards.rs tests
  2. incremented version
  3. ran make card-update
  4. added all the updated files to git and made this PR

@rstad
DKS update
4b84ada
@rstad
after make card-update
d63bdad
@rstad
Update card.rs
c95521f 
typo in smoky lounge name
@rstad
Update card.rs
1df0895 
I have no idea what I have failed in the test, and hope blindly that the split card was it. Probably this will still fail, and I will just wait and see what the real issue is, to be discovered by somebody who actually knows what they're doing.
@jshrake
Copy link
Contributor

jshrake commented Sep 29, 2024 •
edited
Loading

Closing in favor of #58. I ignored the failing test case for now.

@jshrake jshrake closed this Sep 29, 2024
@jshrake
Copy link
Contributor

jshrake commented Sep 29, 2024

Thanks @rstad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rstad @jshrake