Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no context shown on DProtoSyntaxException => should show line number #108

Open
timotheecour opened this issue May 15, 2017 · 3 comments
Open

Comments

@timotheecour
Copy link
Contributor

timotheecour commented May 15, 2017

@msoucy
I have a large proto file, and get this error:

~/.dub/packages/dproto-2.1.1/dproto/import/dproto/parse.d(511,11): Error: uncaught CTFE exception dproto.exception.DProtoSyntaxException("Expected an integer but was ``")

it should show offending line number otherwise really hard to fix

@msoucy
Copy link
Owner

msoucy commented May 18, 2017

Started on the error-lines branch (4cca795)... It fixes scenarios where it's being run for just the string processing, but doesn't yet handle extracting the information from CTFE exceptions.

@timotheecour
Copy link
Contributor Author

@msoucy
also, is showing the contents of the entire proto necessary?
if we had file:line i think showing file:line contents[line] would be enough

@msoucy
Copy link
Owner

msoucy commented May 26, 2017

So the reason that it displays the contents, is that it's not currently being caught so it's dumping the raw exception. I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants