Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Add favicon.ico #17

Open
msoedov opened this issue Nov 12, 2017 · 3 comments
Open

Add favicon.ico #17

msoedov opened this issue Nov 12, 2017 · 3 comments

Comments

@msoedov
Copy link
Owner

msoedov commented Nov 12, 2017

[GIN] 2017/11/12 - 17:34:18 | 200 |     189.572µs | 127.0.0.1 |   GET     /slides.md
[GIN] 2017/11/12 - 17:34:18 | 404 |       6.347µs | 127.0.0.1 |   GET     /favicon.ico
@servusoft
Copy link
Contributor

servusoft commented Feb 25, 2018

@msoedov:
I think,, it is now possible to show the favicon.ico like:

https://github.com/msoedov/hacker-slides/blob/master/main.go#L40

it may seems like:
r.Static("/favicon.ico", "./slides/favicon.ico") or
r.Static("/favicon.ico", "./slides/images/favicon.ico")

@servusoft
Copy link
Contributor

just tried, but it not works.
the /favicon.ico should have his own router.

@msoedov
Copy link
Owner Author

msoedov commented Mar 6, 2018

Just added a base64 favicon #40, no changes to router

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants