Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Bug" in how input bams channel is formed #2

Open
soccin opened this issue Mar 14, 2024 · 0 comments
Open

"Bug" in how input bams channel is formed #2

soccin opened this issue Mar 14, 2024 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@soccin
Copy link
Contributor

soccin commented Mar 14, 2024

I am still new to all this nextflow/channel stuff but I think there is a bug here:

#LINE 44 of realignment.nf
ch_indexed_bams = normal_index.out.bam.join(tumor_index.out.bam)

should be

ch_indexed_bams = tumor_index.out.bam.join(normal_index.out.bam)

because in the gatk_bqsr the first input tuple read:

tuple val(meta), path(tumor_bam), path(tumor_bam_index), path(normal_bam), path(normal_bam_index)

tumor first, normal second. I do not think it matters though for this step as those two bams are treated equally but it is confusing.

https://github.com/mskcc/Arrakis/blob/a13d58c4cbd1f332759b04ef1717753f57fc2181/subworkflows/local/reallignment.nf#L44

@soccin soccin added the question Further information is requested label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants