Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip comma flag even if no comma output implemented #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonhf
Copy link

@simonhf simonhf commented Feb 15, 2020

Addresses half of issue #71 by adding ability to ignore a comma flag -- e.g. #'d -- and not interpret it literally. The result is as if the comma flag is not present, e.g. #d. All existing tests work, and added a new test section for the comma flag.

This pull request at least makes this implementation of printf() compatible with existing code which uses the comma flag... At least seg faults and/or unwanted output no longer occur. Next step will be to implement the comma output with some kind of mechanism to turn it on; environment variable?

@codecov-io
Copy link

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #73   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         359    360    +1     
=====================================
+ Hits          359    360    +1
Impacted Files Coverage Δ
printf.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b9846...cbe0314. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants