Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 deprecation warnings #3150

Open
wagnerand opened this issue May 28, 2024 · 8 comments
Open

v8 deprecation warnings #3150

wagnerand opened this issue May 28, 2024 · 8 comments

Comments

@wagnerand
Copy link
Member

npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated rimraf@2.4.5: Rimraf versions prior to v4 are no longer supported
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@6.0.4: Glob versions prior to v9 are no longer supported

Some of these would need to be resolved in addons-linter (see below), but for web-ext, we should probably replace bunyan by something that is still maintained.

inflight

└─┬ web-ext@8.0.0
  ├─┬ addons-linter@6.28.0
  │ └─┬ eslint@8.57.0
  │   └─┬ file-entry-cache@6.0.1
  │     └─┬ flat-cache@3.2.0
  │       └─┬ rimraf@3.0.2
  │         └─┬ glob@7.2.3
  │           └── **inflight@1.0.6 deduped**
  └─┬ bunyan@1.8.15
    └─┬ mv@2.1.1
      └─┬ rimraf@2.4.5
        └─┬ glob@6.0.4
          └── **inflight@1.0.6**

rimraf

└─┬ web-ext@8.0.0
  ├─┬ addons-linter@6.28.0
  │ └─┬ eslint@8.57.0
  │   └─┬ file-entry-cache@6.0.1
  │     └─┬ flat-cache@3.2.0
  │       └── **rimraf@3.0.2**
  └─┬ bunyan@1.8.15
    └─┬ mv@2.1.1
      └── **rimraf@2.4.5**

glob

└─┬ web-ext@8.0.0
  ├─┬ addons-linter@6.28.0
  │ ├─┬ eslint@8.57.0
  │ │ └─┬ file-entry-cache@6.0.1
  │ │   └─┬ flat-cache@3.2.0
  │ │     └─┬ rimraf@3.0.2
  │ │       └── **glob@7.2.3**
  │ └── glob@10.4.1
  └─┬ bunyan@1.8.15
    └─┬ mv@2.1.1
      └─┬ rimraf@2.4.5
        └── **glob@6.0.4**
@Rob--W
Copy link
Member

Rob--W commented May 28, 2024

addons-linter dependency issues is tracked at mozilla/addons-linter#5311

@Rob--W
Copy link
Member

Rob--W commented May 28, 2024

bunyan's mv dependency issue was reported before at trentm/node-bunyan#719

@wagnerand
Copy link
Member Author

bunyan's mv dependency issue was reported before at trentm/node-bunyan#719

bunyan hasn't seen a release in 3 years and a commit in 2 years. It's probably better to replace it with another logger, than waiting for an update.

@Rob--W
Copy link
Member

Rob--W commented May 28, 2024

bunyan's mv dependency issue was reported before at trentm/node-bunyan#719

bunyan hasn't seen a release in 3 years and a commit in 2 years. It's probably better to replace it with another logger, than waiting for an update.

In that linked issue, the purpose of mv was mentioned. If the feature is not needed by addons-linter, a simpler fix could be to add overrides to our package.json to swap out the mv dependency: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

@fregante
Copy link
Contributor

fregante commented Jul 15, 2024

These two will fix all the issues mentioned here.

@willdurand
Copy link
Member

Yeah. So for eslint v9, most plugins must be compatible and that wasn't the case last time I checked.

@l10nelw
Copy link

l10nelw commented Nov 10, 2024

Unable to install web-ext because of these errors.

(WSL, Windows 10)

@l10nelw
Copy link

l10nelw commented Nov 11, 2024

Apologies, found the issue, NodeJS was installed on Windows itself not on WSL. Very embarrassing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants