bug(settings): Backend events for login_reg and login_complete have gone missing #18059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
reviewed
Nov 25, 2024
dschom
commented
Nov 25, 2024
| @@ -118,23 +119,6 @@ export type AuthServerError = Error & { | |||
| retryAfterLocalized?: string; | |||
| }; | |||
|
|
|||
| export const MetricsContextKeys = [ | |||
There was a problem hiding this comment.
@chenba, This collection was the issue. It didn't contain entrypoint.
dschom
commented
Nov 25, 2024
| */ | ||
| export class MetricsContext { | ||
| deviceId?: string; | ||
| entrypoint?: string; |
There was a problem hiding this comment.
@chenba entrypoint is now a valid 'key' for Metricscontext. With this addition, the query param and is now copied into the metrics context that is sent to the server.
…one missing - Some back end events seemed to disappear - This is due to the entry point not being defined on the event - Fixes missing entrypoint glean data - Ensures entrypoint is sent in graphql requests if it is present in URL - Fixes typo in utm parameter. `utmContext` should have been `utmContent`. - Puts the `MetricContext` model in a shared place to reduce the chance this happens again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
utmContextshould have beenutmContent.MetricContextmodel in a shared place to reduce the chance this happens again.Issue that this pull request solves
Closes: # (issue number)
Checklist
Put an
xin the boxes that apply