Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt GCP authentication flow #5174

Open
scholtzan opened this issue Mar 6, 2024 · 1 comment
Open

Prompt GCP authentication flow #5174

scholtzan opened this issue Mar 6, 2024 · 1 comment

Comments

@scholtzan
Copy link
Collaborator

scholtzan commented Mar 6, 2024

It would be convenient for users that are not logged in to have the gcloud auth flow prompted automatically. Currently, users that are not logged in will see an error message with instructions to perform the authentication themselves.

The tricky part here is that the authentication flow also needs to account for non-interactive environments where no browser is available (testing env, Airflow). We do not want runs in these environments to get stuck, so we need a way to exit runs if no credentials are available.

┆Issue is synchronized with this Jira Task

@sean-rose
Copy link
Contributor

Currently, users that are not logged in will see an error message with instructions to perform the authentication themselves.

Currently users will only get that error message if they have no Google application default credentials at all. Once they've set application default credentials the first time they will no longer get that error message, even if their credentials have expired and they need to re-authenticate. I think different authentication detection logic is needed to handle expired credentials, as suggested in #5171.

The tricky part here is that the authentication flow also needs to account for non-interactive environments where no browser is available (testing env, Airflow). We do not want runs in these environments to get stuck, so we need a way to exit runs if no credentials are available.

Perhaps we could check for standard environment variables always set by CircleCI, Airflow, and/or GKE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants