Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rating): add hourly score graph #74

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

yurijmikhalevich
Copy link
Member

@yurijmikhalevich yurijmikhalevich commented Nov 10, 2024

How does this PR impact the user?

Merge only after:

This PR lets users view the hourly score graph.

image

Loom:
https://www.loom.com/share/0c83f60483e4496db407fb033507708b

Description

  • update rating.get.ts to compute the hourly score graph
  • add the RatingChart to the UI
  • add the setRgbColorOpacity util with tests to support the RatingChart

Limitations

Depending on how useful this one is, we may want to add other kinds of graphs in the future.

Checklist

  • my PR is focused and contains one wholistic change
  • I have added screenshots or screen recordings to show the changes

Copy link
Collaborator

@Bee133 Bee133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.

Base automatically changed from feat/display-24-7-hour-scores to main November 13, 2024 19:38
@yurijmikhalevich yurijmikhalevich changed the title [DO NOT MERGE: waiting for #73] feat(rating): add hourly score graph feat(rating): add hourly score graph Nov 13, 2024
@yurijmikhalevich yurijmikhalevich merged commit f6abb39 into main Nov 13, 2024
2 checks passed
@yurijmikhalevich yurijmikhalevich deleted the feat/display-score-dynamic-graph branch November 13, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants