Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findByExports of CSS modules potential cause of every other reload loading fails/crashes #123

Open
Cynosphere opened this issue Nov 5, 2024 · 0 comments
Open

findByExports of CSS modules potential cause of every other reload loading fails/crashes #123

Cynosphere opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working core This issue is related to moonlight's core core-extension This issue is related to a core extension of moonlight

Comments

@Cynosphere
Copy link
Member

Potential race conditions arise. It used to happen all the time and now it doesn't (probably because of some changes in moonbase to where Margins used the remapped version instead of findByExports), but I was able to replicate when working on an extension (spacepack.findByExports("multipleIconWrapper", "headerIcon")[0].exports).
@Cynosphere Cynosphere added bug Something isn't working core This issue is related to moonlight's core core-extension This issue is related to a core extension of moonlight labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working core This issue is related to moonlight's core core-extension This issue is related to a core extension of moonlight
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cynosphere