Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformatting does not scroll horizontally all the way to the left #84

Open
priyangbhavsar opened this issue Nov 20, 2024 · 4 comments
Open

Reformatting does not scroll horizontally all the way to the left #84

priyangbhavsar opened this issue Nov 20, 2024 · 4 comments
Labels
bug Something isn't working probably fixed? the issue/feature appears to be fixed/implemented, but there still may be issues

Comments

@priyangbhavsar
Copy link

No description provided.

@molsonkiko
Copy link
Owner

Do you really expect me to help you when you give me so little information to go off of?

Show some respect to open source maintainers. Explain what you want. Don't expect us to read your mind.

@priyangbhavsar
Copy link
Author

Focus.time-20241122_120754-Meeting.Recording.mp4

Hi @molsonkiko ,
I have uploaded the video but for some reason, it is not reflecting in the issue, I have added the link to the comment now

@priyangbhavsar priyangbhavsar changed the title Pretty print current JSON takes my cursor to the last point of the Pretty JSON Pretty print current JSON takes my cursor to the last point of the JSON Nov 22, 2024
@molsonkiko molsonkiko changed the title Pretty print current JSON takes my cursor to the last point of the JSON Reformatting scrolls horizontally all the way to the right Nov 22, 2024
@molsonkiko molsonkiko changed the title Reformatting scrolls horizontally all the way to the right Reformatting does not scroll horizontally all the way to the left Nov 22, 2024
@molsonkiko molsonkiko added the bug Something isn't working label Nov 22, 2024
@molsonkiko
Copy link
Owner

@priyangbhavsar
Thanks for explaining your issue. I'm working on this, and I should have a fix out later today.

molsonkiko added a commit that referenced this issue Nov 23, 2024
@molsonkiko
scroll caret into view on reformat; address #84
7c6ce50 
Horizontally scroll all the way to the left when reformatting a file
    (only when reformatting the entire file; not in selection-based mode).
This avoids annoyances when there are very long lines and word wrap is turned off.
@molsonkiko
Copy link
Owner

@priyangbhavsar

I think I understand what you're talking about; when you pretty-print or compress a file with JsonTools, the caret (that is, the place where you can enter text) is moved to the start of the file, but the horizontal scroll is not reset. This issue should be addressed by my latest commit, which you can test by following these instructions. I'm not sure when I will release another version of JsonTools, but it will probably be several weeks at least.

@molsonkiko molsonkiko added the probably fixed? the issue/feature appears to be fixed/implemented, but there still may be issues label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working probably fixed? the issue/feature appears to be fixed/implemented, but there still may be issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@priyangbhavsar @molsonkiko