Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[timer] Fix Timeout::wait implementation #1229

Merged
merged 2 commits into from
Nov 23, 2024
Merged

[timer] Fix Timeout::wait implementation #1229

merged 2 commits into from
Nov 23, 2024
+96 −4

Conversation

salkinium
Copy link
Member

Fixes #1227.

Thanks for finding this!
Added a unit test to catch any regression in future.

cc @WasabiFan

@salkinium salkinium added this to the 2024q4 milestone Nov 20, 2024
WasabiFan
WasabiFan approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@WasabiFan WasabiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium salkinium force-pushed the fix/timeout-wait branch 3 times, most recently from 4f370c9 to 73159ca Compare November 23, 2024 15:36
@salkinium salkinium merged commit fa4c93c into modm-io:develop Nov 23, 2024
12 checks passed
@salkinium salkinium deleted the fix/timeout-wait branch November 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WasabiFan WasabiFan WasabiFan approved these changes

Assignees
No one assigned
Labels
fix 💎 testing 🧪
Milestone
2024q4
Development

Successfully merging this pull request may close these issues.

this_fiber::poll() condition polarity inconsistent
2 participants
@salkinium @WasabiFan