Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish TypeScript branch unit tests #499

Open
javierbrea opened this issue May 21, 2024 · 0 comments
Open

Finish TypeScript branch unit tests #499

javierbrea opened this issue May 21, 2024 · 0 comments
Labels
Milestone

Comments

@javierbrea
Copy link
Member

Unit tests should be completed in the release branch in order to be able to finish the release. The branch has "component" or "functional" tests of each package, but in some packages, such as the "core" one, unit tests were not finished. Old unit tests were deleted because they were completely broken due to the big refactor that was done.

It is desirable to write unit tests also in a "functional", "component" or "acceptance" style, I mean, starting the server programmatically and using its API methods to check real use cases instead of abusing of mocking internal elements. It should be done this way in order to make them more robust, so, in case any other refactor is done, this does not happen again.

The coverage of unit tests should remain very close to 100%, at is previously was. Any exception to this general rule should be explained in the code or in the ignore coverage configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant