Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml should contain sktime and numba as dependencies #1

Open
fkiraly opened this issue Aug 29, 2023 · 1 comment
Open

pyproject.toml should contain sktime and numba as dependencies #1

fkiraly opened this issue Aug 29, 2023 · 1 comment

Comments

@fkiraly
Copy link

fkiraly commented Aug 29, 2023

As far as I can tell from the sktime test suite runs here: sktime/sktime#5178, the package does depend on both numba and sktime via the SFA estimator.

Should this not be added to pyproject.toml?

If not, users installing the package will not have sktime and numba installed when instaling mrseql and will encounter uninformative error messages.

FYI @lnthach

@fkiraly
Copy link
Author

fkiraly commented Aug 30, 2023

Update:

upon closer investigation, the dependency is only there if the feature set includes the "sfa" string. That makes numba and sktime conditional dependencies, only for certain parameter setting.

In this case, I think it makes sense to not make them dependencies of the package, and raise appropriate error messages if the condition is met - the precise condition being the string "sfa" being contained in symrep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant