You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
upon closer investigation, the dependency is only there if the feature set includes the "sfa" string. That makes numba and sktime conditional dependencies, only for certain parameter setting.
In this case, I think it makes sense to not make them dependencies of the package, and raise appropriate error messages if the condition is met - the precise condition being the string "sfa" being contained in symrep.
As far as I can tell from the
sktime
test suite runs here: sktime/sktime#5178, the package does depend on bothnumba
andsktime
via theSFA
estimator.Should this not be added to
pyproject.toml
?If not, users installing the package will not have
sktime
andnumba
installed when instalingmrseql
and will encounter uninformative error messages.FYI @lnthach
The text was updated successfully, but these errors were encountered: