Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict_min_version to manifest.json #9

Open
missmatsuko opened this issue Jul 25, 2019 · 1 comment
Open

Add strict_min_version to manifest.json #9

missmatsuko opened this issue Jul 25, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@missmatsuko
Copy link
Owner

missmatsuko commented Jul 25, 2019

On July 21, 2019, this extension was disabled on addons.mozilla.org (AOM) for not specifying strict_min_version in manifest.json.

This setting is generally optional, but there are some cases where it's required:
AOM - When do you need an add-on ID?

As far as I can tell, this extension does not match any of the criteria above.

I've already updated the add-on's settings in AOM to 54. This is the earliest version where chrome_url_overrides is supported, which contains the configuration that opens the add-on's HTML file whenever new tabs are opened. This setting overrides anything that's set in manifest.json, so I felt that a code change (and new release) was not necessary.
AOM settings. Compatibility field with open tooltip. Tooltip text follows.

Adjusting application information here will allow users to install your add-on even if the install manifest in the package indicates that the add-on is incompatible.

@missmatsuko missmatsuko added the bug Something isn't working label Jul 25, 2019
@missmatsuko
Copy link
Owner Author

Hopefully the add-on will be enabled again soon, but it's entirely dependant on the reviewer(s).

Planning on adding this code change with the next feature, or if someone really wants this to be downloadable on Firefox again.

The review process on AOM has been incredibly frustrating, and a lot of extra work on my part to support ~4 downloads.

If you're looking to add this extension to Firefox and it's still not enabled in AOM, you can also download this repo and load the extension locally.

missmatsuko added a commit that referenced this issue Jan 31, 2020
missmatsuko added a commit that referenced this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant