Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching ( should not match blood types and flags #962

Open
aldenquimby opened this issue Nov 18, 2024 · 0 comments · May be fixed by #963
Open

Searching ( should not match blood types and flags #962

aldenquimby opened this issue Nov 18, 2024 · 0 comments · May be fixed by #963

Comments

@aldenquimby
Copy link

aldenquimby commented Nov 18, 2024 •
edited
Loading

Steps

  • Call SearchIndex.search("(")

Expected

  • Blood type emojis 🅾️ 🅰️ 🅱️ should not match
  • Flags 🇨🇨 🇲🇲 should not match

Actual

  • Those 3 blood type and 2 flag emojis match

Notes

  • Appears the problem is their names include parens
  • e.g. A Button (blood Type) gets converted into ,a,button,(blood,type) for searching

Related problems

  • Searching for burma should match 🇲🇲, and keeling should match 🇨🇨 , but that is not working right now either for the same reason

Proposal
aldenquimby added a commit to aldenquimby/emoji-mart that referenced this issue Nov 18, 2024
@aldenquimby
fix: exclude parens from search name matching missive#962
4784d2e
@aldenquimby aldenquimby linked a pull request Nov 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exclude parens from search name matching #962 aldenquimby/emoji-mart
1 participant
@aldenquimby