Inline cause compile error on MSVC 2013 or earlier

[PerMagnusH]

Hi when compiling with MSVC (VS2013 or earlier) the inline keyword is not supported. Is it possible for you to add a #define inline __inline for MSVC?

[mischasan]

Sure. I'm in a time crunch this week (yes, even for an apparent 3line change in acism.h)
which will amount to:

#ifdef _MSC_VER
#  define inline __inline
#endif//_MSC_VER

Given that only tiny static routines, defining inline as empty may work just as well.
I recall VS2013 ignored almost all inline anyway, unless you went for __forceinline . Sigh.

[mischasan]

Change committed as shown; not tested.

[PerMagnusH]

Thanks! Den mån 25 maj 2020 22:14Mischa Sandberg <notifications@github.com> skrev:

…

Change committed as shown; not tested. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGBGMUL7CGQSN7NPTWH2O53RTLGR7ANCNFSM4NITJV5A> .

[changnet]

newer version Visual Studio(or c++ complier in VS2013) compiling fail since they already have inline keyword defined.
error C1189: The C++ Standard Library forbids macroizing keywords ...
inline: macro redefinition

[mischasan]

Quick fix: insert #undef inline before the #define inline. Will update repo asap

[mischasan]

Working on other (Unix ... SunOS, M1) platforms, the compilers explicitly forbid #defining compiler keywords. Can't say I blame them. Not that there isn't a different workaround.

…

On 23/05/2020, PerMagnusH ***@***.***> wrote: Hi when compiling with MSVC (VS2013 or earlier) the inline keyword is not supported. Is it possible for you to add a #define inline __inline for MSVC? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #33

-- Engineers think equations approximate reality. Physicists think reality approximates the equations. Mathematicians never make the connection.