Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying acism structure to stack may be expensive #11

Open
wjjensen opened this issue Sep 15, 2015 · 0 comments
Open

Copying acism structure to stack may be expensive #11

wjjensen opened this issue Sep 15, 2015 · 0 comments

Comments

@wjjensen
Copy link

For my use case, callgrind highlighted the copying of acism structure from heap to stack in run_match() as occupying about 50% of the time spent overall in run_match(). How much this matters on real hardware, other architectures, or different use cases may vary but it's something to consider.

I replaced it with direct references to the passed in acism struct in the reverse_match branch of my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant