Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement reconnect correctly #1

Open
magiruuvelvet opened this issue Jun 15, 2020 · 0 comments
Open

implement reconnect correctly #1

magiruuvelvet opened this issue Jun 15, 2020 · 0 comments
Assignees
@magiruuvelvet
Labels
bug Something isn't working

Comments

@magiruuvelvet
Copy link
Member

The current reconnect logic is completely broken and I figured out my mistake by now. I'm trying to connect from within the websocket thread which obviously is not going to work and causes a deadlock. Implement the reconnect on the main thread and make sure all other threads are shutdown before doing so.
@magiruuvelvet magiruuvelvet added the bug Something isn't working label Jun 15, 2020
@magiruuvelvet magiruuvelvet self-assigned this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magiruuvelvet magiruuvelvet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magiruuvelvet