Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Extend functionality for Shopify Markets #14

Open
rockeynebhwani opened this issue May 25, 2022 · 3 comments
Open

Suggestion - Extend functionality for Shopify Markets #14

rockeynebhwani opened this issue May 25, 2022 · 3 comments

Comments

@rockeynebhwani
Copy link

We have a situation where we are using Shopify Markets (for US and Canada) and we have a third-party app on PDPs. That functionality is only required on US PDPs and not on Canada PDPs.

Third party app doesn't have support for Shopify Markets. URLs in our case, look like this

www.example.com (For US)
www.example.com/en-ca (For Canada)

All URLs on Canadian sit has '/en-ca' in URL.

If will be great if we have support for suppressing third party JS in certain markets (based on URL patterns).

@rockeynebhwani rockeynebhwani changed the title Suggestion - Suggestion - Extend functionality for Shopify Markets May 25, 2022
@mirceapiturca
Copy link
Owner

Hi @rockeynebhwani ,
Thank you for the suggestion.

There is a PR done for this functionality but unfortunately, I did not merge it to master.
Please have a look at #13 and let me know if this will work for you.

Thanks

@rockeynebhwani
Copy link
Author

@mirceapiturca - I am still new to Shopify and I am not sure if understand all the code in this PR.

Also, when I said 'third-party app' in my comment, I meant this is a Shopify app installed from Shopify app store which we want to block in one of the markets.

In this PR, I couldn't see where are we providing URL pattern for Shopify storefront to block the app based on that URL pattern.

@bredowmax
Copy link

Yes, please!

We are facing exactly the same scenario and so far are using liquid conditionals {% if localization.country.iso_code == "US" %} for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants