-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerize all non-docker boefjes #3859
Draft
Donnype
wants to merge
10
commits into
main
Choose a base branch
from
feature/generic-boefje-container
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donnype
commented
Nov 19, 2024
import httpx | ||
|
||
|
||
def main(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we iterate on this a bit, we should consider a refactor to deduplicate the code between this adapter and the regular one. The behavior is a bit different though, so for both simplicity and clarity, we chose to split them up for now
QA notes on broken boefjes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As the title suggests, this PR introduces a new OCI image having the requirements of all non-docker boefjes. Through the
oci_image
andoci_arguments
we now specify the right script within this generic image. This, in short, is going to be the biggest jump in containerizing our boefjes, converting a total of 27 boefjes. In follow-up PRs, we will add a specialized worker that pulls tasks for this list of oois, and the 13 docker-boefjes will be turned into specialized images having the same interface as well.Issue link
Closes #3698
Demo
QA notes
This is going to be a chunk of work, but to really verify these changes work we need to test whether the following boefjes (by their directory name because I could copy that easily) still run and produce the output we expect:
Another interesting note would be to see if there are any significant performance degradations.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.