Fix for task id as valid UUID #3744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rieven
commented
Oct 28, 2024
| @@ -299,14 +299,15 @@ def list_tasks(self, **kwargs) -> PaginatedTasksResponse: | |||
| filter_key = "filters" | |||
| params = {k: v for k, v in kwargs.items() if v is not None if k != filter_key} # filter Nones from kwargs | |||
| endpoint = "/tasks" | |||
| res = self._client.post(endpoint, params=params, json=kwargs.get(filter_key, None)) | |||
| res = self._client.post(endpoint, params=params, json=kwargs.get(filter_key)) | |||
There was a problem hiding this comment.
this is automatically removed and is not part of this PR. None is already a default return value.
…nation into fix/task-id-as-uuid
We should exclude tests from covarage |
Rieven
commented
Oct 28, 2024
| @@ -57,6 +57,7 @@ def get_context_data(self, **kwargs): | |||
| class NormalizerTaskJSONView(TaskDetailView): | |||
| task_type = "normalizer" | |||
| plugin_type = "normalizer" | |||
| template_name = "tasks/normalizer_task_detail.html" | |||
There was a problem hiding this comment.
My test failed on this part, because it was missing the template name
underdarknl
previously approved these changes
Nov 19, 2024
underdarknl
reviewed
Nov 19, 2024
underdarknl
reviewed
Nov 19, 2024
ammar92
previously approved these changes
Nov 19, 2024
…nation into fix/task-id-as-uuid
underdarknl
reviewed
Nov 20, 2024
underdarknl
reviewed
Nov 20, 2024
underdarknl
reviewed
Nov 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue link
#3743
Closes #3743
Demo
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.